Skip to content

Upgrade jQuery UI version in 2-12-stable branch#8335

Closed
Charles-Mancuso wants to merge 1 commit into
activeadmin:2-12-stablefrom
Charles-Mancuso:2-12-stable
Closed

Upgrade jQuery UI version in 2-12-stable branch#8335
Charles-Mancuso wants to merge 1 commit into
activeadmin:2-12-stablefrom
Charles-Mancuso:2-12-stable

Conversation

@Charles-Mancuso

Copy link
Copy Markdown

This pull request upgrades the jQuery UI version used in the 2-12-stable branch from 1.12.1 to 1.13.3 to address security vulnerabilities.

Changes:

  • Updated the jQuery UI library files in vendor/assets/javascripts/jquery-ui/ and to version 1.13.3.
  • Modified version.js to reflect the new version number.

Testing:

  • Manual tests were conducted to verify that all ActiveAdmin features relying on jQuery UI function correctly with the new version.
  • No issues were observed during runtime, and all unit tests pass.

JavaScript files have been manually updated because:

  • jquery-ui-rails is unmaintained and it is bundling 1.13.0
  • An active fork of jquery-ui-rails is bundling 1.13.2, but there is a more recent version (1.13.3)

escape-selector has been removed because jQuery UI is using jQuery's built-in escape selector. This selector is available from version 3.0, which is required by Active Admin, so it should not be a problem

Ref #8327

Ref:

https://bugs.jqueryui.com/ticket/14991/
jquery/jquery-ui#1957


Tests that were performed manually:


Thank you for considering this upgrade. I look forward to your feedback.

@javierjulio

Copy link
Copy Markdown
Member

@Charles-Mancuso we don't support v2 anymore. Please update to v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants