Template and styles clean up#8197
Merged
Merged
Conversation
These are no longer needed and have been replaced by the native HTML date input. The DatepickerInput was for jQuery UI but has since been removed. Formtastic already supports specifying `input_html` which will allow users to use a custom date picker if they want.
Since it was only used here. It was previously in the resource comments before partial extraction but no need there since the partial is meant to be copied and modified by host app.
This doesn't seem to have ever been completed but mongo should still be usable. We have introduced other ActiveRecord error handling so may be unavoidable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8197 +/- ##
==========================================
- Coverage 99.03% 99.03% -0.01%
==========================================
Files 151 149 -2
Lines 4150 4127 -23
==========================================
- Hits 4110 4087 -23
Misses 40 40 ☔ View full report in Codecov by Sentry. |
This inlines the previous boilerplate class into the generator since no need to hide this behind a flag. We want the generated boilerplate to be the default. It should be active (uncommented) so it can be tried out and modified. We want users to rely on declaring their resource pages rather than rely on defaults-rendering.
Originally, tried this but had some trouble. When applying RTL support for the nested menu icon, I looked up using group with data attribute and found this: tailwindlabs/tailwindcss#11768 (comment) With this applied the group class approach was working. This is ideal since now our JS is just toggling a simple data attribute and has no classes to set/remove. This also works with the RTL modifier. No need for additional Ruby here to set the class if its current, since we can just base it off the data attribute now.
b8dae7f to
9420329
Compare
We need this in templates because when generating a dev app (rails_templates_with_data) if we enable authorization adapter for testing we receive errors regarding this model. Test suite is unaffected by this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes minor clean up of templates and styles after review, to prep for a beta release.
Since we long removed jQuery and jQuery UI, this removes the date picker inputs as they are no longer needed. We default to the native HTML date input which users can override with their own custom date picker JS.
This adds a sorted icon to the
table_forcomponent as this was the final, missing UI piece for our data table styles. Some icons were not rendered correctly in RTL and have been fixed.The resource generator now outputs the boilerplate by default with it uncommented so users are directed to configure their resource page rather than rely on defaults-rendering.
The main menu script now only toggles a
data-openattribute. No need to set/remove CSS classes as we now use a Tailwind group modifier to hide/display the nested menu list and rotate the icon, for RTL as well.