Update nl.yml for v4#8195
Merged
Merged
Conversation
V4 introduces changes in pagination. Also: chose "reactie" instead of "commentaar" (both translations were in use).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8195 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 151 151
Lines 4150 4150
=======================================
Hits 4110 4110
Misses 40 40 ☔ View full report in Codecov by Sentry. |
javierjulio
reviewed
Dec 30, 2023
javierjulio
left a comment
Member
There was a problem hiding this comment.
@caifara thank you. 👏🏻 This is missing a single v4 default change. Would you mind translating the status_tag.unset from "No" to "Unknown" in the Dutch equivalent? The default was changed to separate false from nil, e.g. in the case of booleans.
Contributor
Author
|
@javierjulio done, thank you for all your effort! |
javierjulio
approved these changes
Dec 30, 2023
javierjulio
left a comment
Member
There was a problem hiding this comment.
@caifara thank you for your support and contribution! I really appreciate it. ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts V4 i18n changes for Dutch translations.
Also: chose "reactie" instead of "commentaar" (as both translations were in use).