Skip to content

Prep Tailwind CSS migration part 8#8170

Merged
javierjulio merged 18 commits into
masterfrom
tailwind-part-8
Dec 13, 2023
Merged

Prep Tailwind CSS migration part 8#8170
javierjulio merged 18 commits into
masterfrom
tailwind-part-8

Conversation

@javierjulio

Copy link
Copy Markdown
Member

This continues styling details for various components such as active filters which simplified content and layout. The actions dropdown option had to be removed due to issue with a responsive table. This also updates the index-list component to share the same styles as scopes as it did before. Includes some updates/fixes from browser testing.

@javierjulio javierjulio self-assigned this Dec 12, 2023
@codecov

codecov Bot commented Dec 12, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (582a03c) 99.00% compared to head (8fb8b06) 98.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8170      +/-   ##
==========================================
- Coverage   99.00%   98.99%   -0.01%     
==========================================
  Files         173      172       -1     
  Lines        4628     4597      -31     
==========================================
- Hits         4582     4551      -31     
  Misses         46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio force-pushed the tailwind-part-8 branch 2 times, most recently from 9d984a0 to 8c102f6 Compare December 12, 2023 02:07
No need for these on form controls since it already inherits base which is what we want. This way we can control font size from container.
We don't use these. Simple enough for users to provide themselves. We'll have a new attributes_list component that uses dl/dt/dd elements which allow for easier styling in general and for smaller viewports.
The original selector using `:has` wouldn't work in current version of Firefox. This was just a clever way to apply the styles in a specific context but was only for Devise forms which don't matter since we expect users to customize them. We can apply a simple default in the template to grow the flex container when its the only action.
Now that we've extracted the site header, page header and site footer, there is no need for a default link style since it's expected that this will be customized by users. We can limit the link style to just the page content container as a default there where it makes most sense. With how its defined, the links should be able to be overridden with Tailwind utilities now.
This has scrolling issues within a responsive table for mobile support. We'll maintain the actions as-is which is a better default for the admin. Users can already specify custom columns so they can add a dropdown or another custom component if they want without depending on ActiveAdmin for providing it.
@javierjulio javierjulio merged commit 5c940f9 into master Dec 13, 2023
@javierjulio javierjulio deleted the tailwind-part-8 branch December 13, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant