Prep Tailwind CSS migration part 8#8170
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8170 +/- ##
==========================================
- Coverage 99.00% 98.99% -0.01%
==========================================
Files 173 172 -1
Lines 4628 4597 -31
==========================================
- Hits 4582 4551 -31
Misses 46 46 ☔ View full report in Codecov by Sentry. |
9d984a0 to
8c102f6
Compare
No need for these on form controls since it already inherits base which is what we want. This way we can control font size from container.
We don't use these. Simple enough for users to provide themselves. We'll have a new attributes_list component that uses dl/dt/dd elements which allow for easier styling in general and for smaller viewports.
The original selector using `:has` wouldn't work in current version of Firefox. This was just a clever way to apply the styles in a specific context but was only for Devise forms which don't matter since we expect users to customize them. We can apply a simple default in the template to grow the flex container when its the only action.
Now that we've extracted the site header, page header and site footer, there is no need for a default link style since it's expected that this will be customized by users. We can limit the link style to just the page content container as a default there where it makes most sense. With how its defined, the links should be able to be overridden with Tailwind utilities now.
This has scrolling issues within a responsive table for mobile support. We'll maintain the actions as-is which is a better default for the admin. Users can already specify custom columns so they can add a dropdown or another custom component if they want without depending on ActiveAdmin for providing it.
8c102f6 to
30e648c
Compare
30e648c to
b429ebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues styling details for various components such as active filters which simplified content and layout. The actions dropdown option had to be removed due to issue with a responsive table. This also updates the index-list component to share the same styles as scopes as it did before. Includes some updates/fixes from browser testing.