Use active_admin_authorization as Ransack auth_object option#8143
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8143 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 182 182
Lines 4722 4722
=======================================
Hits 4677 4677
Misses 45 45 ☔ View full report in Codecov by Sentry. |
5c0fc02 to
6137289
Compare
9b02bd4 to
26d0d0a
Compare
fixes activeadmin#8108 The issue suggest to use `active_admin_authorization` as auth_object. It make sense to me. I'm not implementing the idea of a default implementation of ransackable attributes. That doesn't seems easy to me. I would appreciate a PR or a battle tested example for that.
26d0d0a to
d928873
Compare
|
Sorry, is this going to be released anytime soon? I saw that was merged, but still in 3.2.1 is not released |
|
@baldarn it is already released in v4. This change was seen as a breaking change so we won't release on v3. |
|
@javierjulio sorry to reopen the discussion but v4 is not released as a stable version yet and is a huge change. Would it be possible to reconsider releasing it on v3 ? |
we added a simple patch in our app to get this feature. just monkey patch
and you are good to go! |
|
@qdegraeve those that worked on the feature view it as a breaking change and I trust that so no sorry it will not be released in v3. I don't see much concern either since it's a one line change in a two line method that hasn't been modified since it's original implementation and Metasearch-to-Ransack migration over a decade ago. As @baldarn mentioned it is simple and safe to just monkey patch if you need the behavior now on v3. Thank you. |
|
Thanks for your reply, I'll add the patch as well |
fixes #8108
The issue suggest to use
active_admin_authorizationas auth_object. It make sense to me.I'm not implementing the idea of a default implementation of ransackable attributes. That doesn't seems easy to me. I would appreciate a PR or a battle tested example for that.