Prep Tailwind CSS migration part 3#8037
Merged
Merged
Conversation
The idea is to rely on partials that users declare rather than a DSL so full customization is possible. The batch action now accepts a partial where a user can provide the modal HTML (should be hidden) and link html options so a data attribute can be specified that will open the modal form on click. A delegated form submit event handler is applied for a matching form element by data attribute. The form submission works the same as it did before, providing the same fields.
Reviewing past changes, all references were removed.
The inputs don't change in size so they shouldn't be relative to the font size of the element they are within so instead of em they should use rem. The checkbox indeterminate styles are fixed now as well.
53a6255 to
87c8753
Compare
87c8753 to
ecd5318
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #8037 +/- ##
==========================================
+ Coverage 98.89% 99.04% +0.15%
==========================================
Files 184 185 +1
Lines 4698 4731 +33
==========================================
+ Hits 4646 4686 +40
+ Misses 52 45 -7
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the initial prep work as it adds the batch actions form DSL replacement. The test suite is stable. From here we'll continue to modify the CSS and styles of all components.