run update_resource inside a transaction to avoid autosaving relationships through assign_attributes when the record is invalid #6202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ships through assign_attributes when the record is invalid
Author
|
I need some help with the regression tests... Can anybody point me in the right direction? |
|
Tested on real project. Works fine 👍 |
Author
|
closing due to lack of help... I hope this works already on the stable branches |
Member
|
Thanks @arbesulo, sorry nobody was able to help out. I created an updated copy of this PR, this seems useful work, so by keeping an open PR maybe some will eventually get to ir. |
Member
|
By the way, this seems like a Rails issue? Is there any open report about this? |
Author
|
@deivid-rodriguez honestly I haven't checked if there is any open issue in rails related to this. Also I'm no longer in the project where this issue arised, so I don't know if the current version still has it or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5430
When submitting a form with invalid attributes, some associations are autosaved via
assign_attributesbefore callingsave_resource. As a consequence, when updating a resource, the user sees a validation error and is not aware that the changes to the associations got persisted.This PR runs the code inside the
update_resourcemethod in anActiveRecord::Transactionso that everything is rolled back when the model is not valid.