Extract Sidebar View Component#5206
Merged
varyonic merged 1 commit intoactiveadmin:masterfrom Nov 3, 2017
Merged
Conversation
zorab47
approved these changes
Nov 3, 2017
Contributor
|
@varyonic what approaches do you take when overriding/extending components? It is primarily monkey-patching? Due to their construction it is difficult to re-associate the builder method ( |
Fivell
approved these changes
Nov 3, 2017
Contributor
Author
|
@zorab47 I will have another PR that shows my approach shortly. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it easier to override and customize all of the sidebar, not just the sections.