Skip to content

Fix #pluck method behavior when 3+ attributes specified#269

Merged
kbrock merged 2 commits intoactive-hash:masterfrom
h6ah4i:fix/pluck-more-than-two-attrs
Nov 28, 2022
Merged

Fix #pluck method behavior when 3+ attributes specified#269
kbrock merged 2 commits intoactive-hash:masterfrom
h6ah4i:fix/pluck-more-than-two-attrs

Conversation

@h6ah4i
Copy link
Contributor

@h6ah4i h6ah4i commented Nov 28, 2022

Hi. I noticed that ActiveHash's #pluck method behaves differently from ActiveRecord one. This pull request fixes the issue.

Current behavior (ActiveHash v3.1.1)

Category.pluck(:id, :name, :language)
=> [
  [[1, "US"], "English"],
  [[2, "Canada"], "English"],
  [[3, "Mexico"], "Spanish"]
]

Expected behavior (same as ActiveRecord)

Category.pluck(:id, :name, :language)
=> [
  [1, "US", "English"],
  [2, "Canada", "English"],
  [3, "Mexico", "Spanish"]
]

@h6ah4i h6ah4i force-pushed the fix/pluck-more-than-two-attrs branch from d863fc0 to 0c9fda6 Compare November 28, 2022 07:37
@kbrock kbrock added the bug label Nov 28, 2022
kbrock
kbrock approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for the tests

@kbrock kbrock merged commit cd24253 into active-hash:master Nov 28, 2022
@iberianpig iberianpig mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbrock kbrock kbrock approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h6ah4i @kbrock