docs: add an annotation example in Additional Tweaks#600
Merged
mumoshu merged 1 commit intoactions:masterfrom Jun 3, 2021
pdemagny:tweaks-annotations
Merged
docs: add an annotation example in Additional Tweaks#600mumoshu merged 1 commit intoactions:masterfrom pdemagny:tweaks-annotations
mumoshu merged 1 commit intoactions:masterfrom
pdemagny:tweaks-annotations
Conversation
mumoshu
reviewed
Jun 3, 2021
Collaborator
mumoshu
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for your contribution @pdemagny!
// Just curious, but were you able to successfully let cluster-scaler bring down the node running runners by using this annotation?
// Just asking because I'm gathering more samples of how everyone's using various configurations 😉
mumoshu
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks a lot for actions-runner-controller, it is simple to get started, quite efficient, and fits perfectly for my use case !
Here is an humble contribution that would help for #262 and hopefully avoid a few people some head-scratching ;)