Recommend updating branches for major versions and not tags in the versioning docs#631
Closed
eregon wants to merge 1 commit intoactions:masterfrom
Closed
Recommend updating branches for major versions and not tags in the versioning docs#631eregon wants to merge 1 commit intoactions:masterfrom
eregon wants to merge 1 commit intoactions:masterfrom
Conversation
|
@eregon, did you ever get any feedback about this PR? |
|
@ GitHub Team, why is such an important PR not merged yet. Even no reaction to it? How is it even possible that GitHub developers have such a bad knowledge about Git and it's behavior as well as the internal implementation of Git. Suggesting to move tags is not just bad practice... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be an obvious change.
gittags should not be moved, I would hope GitHub knows that, since mostgitusers do.For instance see what the
git tagman page says about moving a tag: https://git-scm.com/docs/git-tag#_on_re_taggingTo keep it short, the man page calls moving a tag
The insane thing.. Should be clear it's an anti-pattern.It also explains there are various problems if users already saw the old tag, and it will not be updated for them on
git pullwhich might result in confusion (e.g.,git pull; git checkout v1might checkout an old version of the tag).A branch is what naturally moves in
git.Are there any advantages to use a moving tag for major versions? I don't see any.
Also this naturally prevents unintentionally going back with a major version:
So, how about recommending best
gitpractices in the official versioning documentation of GitHub Actions with this PR?Related: #214 (comment)