Skip to content

Use posix archive format#533

Merged
konradpabjan merged 2 commits intoactions:mainfrom
smorimoto:posix-archive-format
Aug 5, 2020
Merged

Use posix archive format#533
konradpabjan merged 2 commits intoactions:mainfrom
smorimoto:posix-archive-format

Conversation

@smorimoto
Copy link
Copy Markdown
Contributor

@smorimoto smorimoto commented Jul 29, 2020 •
edited
Loading

See #475 for details.

Closes: actions/cache#326

@smorimoto smorimoto force-pushed the posix-archive-format branch from 2657240 to ca5af8e Compare July 29, 2020 15:32
@smorimoto
Use posix archive format
2de8727 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto force-pushed the posix-archive-format branch from ca5af8e to 2de8727 Compare July 29, 2020 15:33
@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Jul 29, 2020

@aiqiaoy This should now be in a mergeable state. Could you review it?

@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Jul 31, 2020

CC: @joshmgross

@joshmgross joshmgross requested a review from aiqiaoy July 31, 2020 14:08
@joshmgross joshmgross added cache enhancement New feature or request labels Jul 31, 2020
@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Jul 31, 2020

Related issue: actions/cache#326

konradpabjan
konradpabjan suggested changes Aug 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small request to change the package version to 1.0.2 in all the places. Overall looks good! Thanks for submitting this PR ❤️

CC @aiqiaoy

packages/cache/src/internal/tar.ts
}
}
const args = [
'--posix',
Copy link
Copy Markdown
Contributor

@konradpabjan konradpabjan Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over the previous PR, I think this won't cause any compat issues. No objections from me 👍

Copy link
Copy Markdown
Contributor Author

@smorimoto smorimoto Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this shouldn't cause any problems.

@smorimoto smorimoto force-pushed the posix-archive-format branch from 1b2a3cd to 7737589 Compare August 4, 2020 20:15
@smorimoto smorimoto requested a review from konradpabjan August 4, 2020 20:15
@smorimoto
Update package.json and RELEASES.md
3be5c33 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto force-pushed the posix-archive-format branch from 7737589 to 3be5c33 Compare August 4, 2020 20:16
@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Aug 5, 2020

@konradpabjan Thanks for your review.

@aiqiaoy
Copy link
Copy Markdown
Contributor

aiqiaoy commented Aug 5, 2020

Yeah sorry I was on-call when I reviewed the original PR and completely forgot about following up. Looks good!

@konradpabjan konradpabjan merged commit 9ad01e4 into actions:main Aug 5, 2020
@konradpabjan
Copy link
Copy Markdown
Contributor

konradpabjan commented Aug 5, 2020

Version 1.0.2 has been published: https://www.npmjs.com/package/@actions/cache/v/1.0.2

@smorimoto smorimoto deleted the posix-archive-format branch August 5, 2020 19:49
@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Aug 5, 2020

@konradpabjan Thanks again for your work :)

@smorimoto
Copy link
Copy Markdown
Contributor Author

smorimoto commented Aug 5, 2020

@aiqiaoy No worries! I sometimes do something similar to you.

This was referenced Aug 5, 2020
Merged
Closed
@dhadka dhadka mentioned this pull request Oct 3, 2020
Closed
@dbalde dbalde mentioned this pull request Jun 20, 2023
Open
@LadyK-21 LadyK-21 mentioned this pull request Jun 20, 2023
Open
@eliasbuchwald eliasbuchwald mentioned this pull request Jun 20, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Jun 21, 2023
Open
@Jsn2win Jsn2win mentioned this pull request Jun 21, 2023
Open
@Oleksandr1201vsp Oleksandr1201vsp mentioned this pull request Jun 21, 2023
Open
This was referenced Jun 21, 2023
Open
Open
@Oleksandr1201vsp Oleksandr1201vsp mentioned this pull request Jun 21, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
@Oleksandr1201vsp Oleksandr1201vsp mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aiqiaoy aiqiaoy aiqiaoy approved these changes

+1 more reviewer

@konradpabjan konradpabjan konradpabjan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cache enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preserve exact timestamps

4 participants

@smorimoto @aiqiaoy @konradpabjan @joshmgross