Skip to content

Conversation

@salmanmkc
Copy link
Contributor

Summary

This PR updates the @azure/storage-blob dependency in @actions/cache to fix the punycode deprecation warning in Node.js 24.

Problem

The previous dependency chain caused a deprecation warning in Node.js 24:

@azure/storage-blob@^12.13.0
  └── @azure/core-http@^3.0.0
        └── node-fetch@2.x
              └── whatwg-url@5.x
                    └── tr46@0.0.3
                          └── punycode (deprecated)

Node.js 24 deprecates the built-in punycode module, causing warnings when running actions.

Solution

  • Updated @azure/storage-blob from ^12.13.0 to ^12.29.1

The newer @azure/storage-blob@12.23.0+ uses @azure/core-rest-pipeline instead of the deprecated @azure/core-http, which eliminates the problematic dependency chain entirely. The @actions/cache package already had @azure/core-rest-pipeline as a direct dependency, so this change aligns the storage-blob version with the modern Azure SDK approach.

Testing

  • TypeScript compiles successfully
  • npm ls tr46 returns empty (punycode dep removed)
  • npm ls @azure/core-http returns empty

Related

  • Part of Node.js 24 migration effort for GitHub Actions

…precation

- Updated @azure/storage-blob from ^12.13.0 to ^12.29.1
- Newer storage-blob uses @azure/core-rest-pipeline instead of deprecated @azure/core-http
- Fixes Node.js 24 deprecation warning for punycode module
@salmanmkc salmanmkc requested a review from a team as a code owner December 12, 2025 13:46
Copilot AI review requested due to automatic review settings December 12, 2025 13:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @azure/storage-blob dependency in the @actions/cache package to address Node.js 24's punycode deprecation warning. The update eliminates the problematic dependency chain that went through @azure/core-httpnode-fetchwhatwg-urltr46punycode.

Key changes:

  • Updated @azure/storage-blob from ^12.13.0 to ^12.29.1 to use modern Azure SDK with @azure/core-rest-pipeline

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@salmanmkc salmanmkc merged commit 8734e57 into main Dec 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants