Update setup-ruby in Jekyll workflow to support ubuntu-24.04#2538
Closed
kachick wants to merge 1 commit intoactions:mainfrom
kachick:bump-setup-ruby-in-jekyll
Closed
Update setup-ruby in Jekyll workflow to support ubuntu-24.04#2538kachick wants to merge 1 commit intoactions:mainfrom kachick:bump-setup-ruby-in-jekyll
kachick wants to merge 1 commit intoactions:mainfrom
kachick:bump-setup-ruby-in-jekyll
Conversation
mScott224
approved these changes
Dec 8, 2024
|
Obsoleted by #2720 |
Contributor
Author
|
Thanks for letting me know! I close this PR. However I don't know why they intentionally avoid the comment style from dependabot/dependabot-core#4691 in #2720 |
|
@kachick Agreed. The inconsistencies are indeed weird. (Some of the later additions come from vendors and the reviews approve that without any objections, even when such changes don't follow the actual rules about pinning and 3rdparty disclosure stated in the contributing templates etc. … I gave up, as the maintainers did apparently too…;D) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would prevent same problem such as ruby/setup-ruby#595 (comment)
Now ubuntu-latest points to ubuntu-24.04 # actions/runner-images#10636
starter-workflows/pages/jekyll.yml
Line 32 in 666350e
Pre-requisites
Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.
Tasks
For all workflows, the workflow:
.ymlfile with the language or platform as its filename, in lower, kebab-cased format (for example,docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").GITHUB_TOKENso that the workflow runs successfully.For CI workflows, the workflow:
cidirectory.ci/properties/*.properties.jsonfile (for example,ci/properties/docker-publish.properties.json).pushtobranches: [ $default-branch ]andpull_requesttobranches: [ $default-branch ].releasewithtypes: [ created ].docker-publish.yml).For Code Scanning workflows, the workflow:
code-scanningdirectory.code-scanning/properties/*.properties.jsonfile (for example,code-scanning/properties/codeql.properties.json), with properties set as follows:name: Name of the Code Scanning integration.creator: Name of the organization/user producing the Code Scanning integration.description: Short description of the Code Scanning integration.categories: Array of languages supported by the Code Scanning integration.iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in theiconsdirectory.pushtobranches: [ $default-branch, $protected-branches ]andpull_requesttobranches: [ $default-branch ]. We also recommend ascheduletrigger ofcron: $cron-weekly(for example,codeql.yml).Some general notes:
actionsorganization, or