Relax limitation on entrypoint allowing container actions to be executed without the entrypoint specified#77
Merged
nikola-jokic merged 1 commit intomainfrom Jul 17, 2023
Conversation
b6399ee to
a3171d6
Compare
a3171d6 to
9eaacb7
Compare
fhammerl
approved these changes
Jul 17, 2023
Contributor
fhammerl
left a comment
There was a problem hiding this comment.
LGTM!
We no longer write the entrypoint into a sh script and execute it on the container when the step is started, instead we set it as a pod command and let it be invoked when the container is started.
This means prependPath is now unavailable in container steps - prependPath only has utility for jobContainers so this is not a breaking (or any) change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76