Mount /github/workflow to docker action pods#137
Merged
nikola-jokic merged 2 commits intoactions:mainfrom Mar 14, 2024
Merged
Conversation
0eba66a to
da33cec
Compare
|
Thanks for that PR. Trying to run the docker container action super-linter action in v5 with the actions runner controller in container mode kubernetes lead me here. It fails with |
|
What do you think @nikola-jokic , does this sound like a reasonable change? Is there a reason, why it is different for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/github/workflowis set via env GITHUB_EVENT_PATH also in docker actions.Such path is mount in container jobs pods, and should be(?) mount in similar fashion in other child pods (in this case docker action pods), especially that some docker actions from marketplace, use this path.
Having it inconsistent for container job pod and for docker action pod, makes it impossible to use with ACTIONS_RUNNER_CONTAINER_HOOK_TEMPLATE and mount via extension, which is shared for both - it will work for docker action pods, but will fail for container job pod (duplicate mount point).
Adding it as default mount seems the only option to be able to properly utilize this ENV (and events in general).