You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What I would suggest for the ADR is to follow the same practice we are doing in actions runner controller.
To do that, you should create a new file, with the name: ADR [Number of the PR]: Hook extensions. We should probably change the numbering, but this is currently how we are doing it in the hook. Then, mark the previous file as Superceded and add the footnote referencing your new ADR. Then, update the information in the ADR and that is it 😄
What I would suggest for the ADR is to follow the same practice we are doing in actions runner controller. To do that, you should create a new file, with the name: ADR [Number of the PR]: Hook extensions. We should probably change the numbering, but this is currently how we are doing it in the hook. Then, mark the previous file as Superceded and add the footnote referencing your new ADR. Then, update the information in the ADR and that is it 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nikola-jokic
left a comment
Related to discussion under: #132
@nikola-jokic not sure how to upgrade ADR (what is your process) - awaiting your recommendation