(In progress) Refactor Codebase to Support Modular Composite Actions #584
Closed
ethanchewy wants to merge 3 commits intomasterfrom
Closed
(In progress) Refactor Codebase to Support Modular Composite Actions #584ethanchewy wants to merge 3 commits intomasterfrom
ethanchewy wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
|
Actually, we would need to make another ExecutionContext for our Composite Actions StepsRunner to make sense as well. Hmmmmm... I'll try to do both refactorings at the same time and see how it goes. If it becomes to large, I'll try to seperate the logic. |
Contributor
Author
|
Yup, gonna create another PR based on the master branch for the Global Execution Context refactoring. That makes the most sense. |
Contributor
Author
|
Closing. Will create another branch since we elected to choose a different route for refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we plan to support recognizing any type of steps in a composite action.
We are going to accomplish this by doing:
Refactoring StepsRunner to ensure that it's only used for Job Level Steps
Create a separate StepsRunner for only Composite Actions
Modify existing code to parse through every type of step
Refactor Execution Context
** Let's first start with seperating the composite stuff from the execution context and packaging that into the composite execution context.
Additional changes that we might do in this PR or another PR depending on complexity:
High level view: https://docs.google.com/document/d/1euUp55hp0CcAuaoATDieVvJMUTFbHc6zveNaTEKIY8A/edit#