Skip to content

Continue on error for the composite actions#1763

Merged
thboop merged 13 commits intoactions:mainfrom
nikola-jokic:nikola-jokic/enhancement/1457
Apr 1, 2022
Merged

Continue on error for the composite actions#1763
thboop merged 13 commits intoactions:mainfrom
nikola-jokic:nikola-jokic/enhancement/1457

Conversation

@nikola-jokic
Copy link
Copy Markdown
Contributor

@nikola-jokic nikola-jokic commented Mar 17, 2022

Fixes #1457

@nikola-jokic nikola-jokic requested a review from a team as a code owner March 17, 2022 15:02
@thboop thboop requested a review from fhammerl March 21, 2022 12:51
Copy link
Copy Markdown
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure we remove secrets from the allowed contexts before merging this

ghost
ghost previously approved these changes Mar 27, 2022
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Could you please link to an example test workflow displaying a successful run?

@nikola-jokic
Copy link
Copy Markdown
Contributor Author

Example workflow file:

name: "Continue on Error"

on:
  workflow_dispatch:
  
jobs:
  composite_showcase:
    runs-on: self-hosted
    name: "Showcase continue-on-error"
    steps:
      - name: Continue on error showcase
        uses: nikola-jokic/composite@main
      - name: Log finished
        run: echo 'Finished...'

Inside the composite action:

runs:
  using: "composite"
  steps:
  - name: Run failing
    run: exit 1
    continue-on-error: true
    shell: bash
  - name: Uses failing
    uses: nikola-jokic/failing-composite@main
    continue-on-error: true
  - name: Echo OK
    run: echo 'OK'
    shell: bash

Failing composite action:

name: 'Failing composite'
description: 'Composite failing'

runs:
  using: "composite"
  steps:
    - name: Err
      run: exit 1
      shell: bash

Final workflow run image:
continue-on-error

@Jessev6
Copy link
Copy Markdown

Jessev6 commented Apr 1, 2022

@thboop Are the changes you requested done? I would really like to use this feature 😄

Copy link
Copy Markdown
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop thboop merged commit d70f9f6 into actions:main Apr 1, 2022
@cytopia
Copy link
Copy Markdown

cytopia commented Apr 1, 2022

@thboop is this feature available with your merge from above or does it require an additional deployment?

@nikola-jokic nikola-jokic deleted the nikola-jokic/enhancement/1457 branch April 1, 2022 13:51
@tahirmt
Copy link
Copy Markdown

tahirmt commented Apr 12, 2022

Any idea when this will be released? the latest release was two days before this was merged

@bond-
Copy link
Copy Markdown

bond- commented Sep 7, 2022

Hi all, which version of GH enterprise has this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to use continue-on-error from composite Action steps

8 participants