Skip to content

Fix event action check#354

Merged
ncalteen merged 2 commits intomainfrom
ncalteen/event
Sep 22, 2025
Merged

Fix event action check#354
ncalteen merged 2 commits intomainfrom
ncalteen/event

Conversation

@ncalteen
Copy link
Copy Markdown
Collaborator

This pull request standardizes how the GitHub event action is accessed throughout the codebase. Previously, the code sometimes used github.context.action and other times used github.context.payload.action, which could lead to inconsistencies and bugs. The updates ensure that all logic and tests consistently reference github.context.payload.action.

@ncalteen ncalteen requested a review from salmanmkc September 16, 2025 17:00
@ncalteen ncalteen self-assigned this Sep 16, 2025
@ncalteen ncalteen requested a review from a team as a code owner September 16, 2025 17:00
Copilot AI review requested due to automatic review settings September 16, 2025 17:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request standardizes GitHub event action access by consistently using github.context.payload.action instead of the inconsistent mix of github.context.action and github.context.payload.action that was previously used throughout the codebase.

  • Updated main logic to use github.context.payload.action for event action checks
  • Updated test setup and assertions to use the standardized payload property
  • Moved the action property from the root context to the payload object in fixtures

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
src/main.ts Updated event action check to use payload.action
tests/main.test.ts Updated test setup and assertions to use payload.action
fixtures/@actions/github.ts Moved action property from root context to payload object

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ncalteen ncalteen merged commit 33689d3 into main Sep 22, 2025
19 checks passed
@martinkov2023-glitch
Copy link
Copy Markdown

Pull Request Overview

This pull request standardizes GitHub event action access by consistently using github.context.payload.action instead of the inconsistent mix of github.context.action and github.context.payload.action that was previously used throughout the codebase.

  • Updated main logic to use github.context.payload.action for event action checks
  • Updated test setup and assertions to use the standardized payload property
  • Moved the action property from the root context to the payload object in fixtures

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
src/main.ts Updated event action check to use payload.action
tests/main.test.ts Updated test setup and assertions to use payload.action
fixtures/@actions/github.ts Moved action property from root context to payload object

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants