This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Target commitish#19
Closed
Sander0542 wants to merge 9 commits intoactions:masterfrom
Sander0542:target_commitish
Closed
Target commitish#19Sander0542 wants to merge 9 commits intoactions:masterfrom Sander0542:target_commitish
Sander0542 wants to merge 9 commits intoactions:masterfrom
Sander0542:target_commitish
Conversation
Get the input from the core Add the parameter to the createRelease
|
Thanks a lot @Sander0542. I also need this input added. Would it be possible to please check the failing tests, so that this PR can be reviewed and merged? |
|
@Sander0542 : I would really need the changes of this PR. Are you still working on it? |
Author
|
Hi @davelosert, You can take this PR over. I don't have time to fix it. Thanks! |
|
I just saw that PR #32 also fixes this issue - and additionally adds the current context.sha as the default comittish. I think that is a bit of a better approach as in here where it still defaults to master, so I think #32 should be preffered to merge over this here. Sorry @Sander0542 . |
Author
|
I agree with that @davelosert. PR #32 looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.