Conversation
Contributor
|
I thought the previous PR was created to sort the files to be cached. Why remove that sort? |
Contributor
Author
|
@Phantsure That can be done in the save.ts / restore.ts file separately only for the path array, but not in the getInput fxn. Should I add that change as well ? |
Contributor
|
If that already didn't exist then we have to think if it would break anything |
Contributor
Author
|
@Phantsure Then it's good to just remove sort here and merge this today as a fix. |
This was referenced Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #941.
This bug was introduced with this commit https://github.com/actions/cache/pull/903/files and also sorts restore-keys which we don't want. Initial intention was to sort paths only.
This PR removes sorting completely. We can discuss later if we want to sort paths separately in save.ts / restore.ts .
After merging this, we'll need to release a new cache version immediately to fix this bug.