Remove final incorrect instances of %AppData% / %LocalAppData% from Windows cache examples#762
Merged
vsvipul merged 1 commit intoactions:mainfrom May 11, 2022
magnetikonline:remove-win-load-app-data
Merged
Remove final incorrect instances of %AppData% / %LocalAppData% from Windows cache examples#762vsvipul merged 1 commit intoactions:mainfrom magnetikonline:remove-win-load-app-data
%AppData% / %LocalAppData% from Windows cache examples#762vsvipul merged 1 commit intoactions:mainfrom
magnetikonline:remove-win-load-app-data
Conversation
…r Windows cache examples
Contributor
|
Will wait for someone to test if this really makes any difference on windows. @jheysaav . If you want to test @magnetikonline can use https://github.com/duxtland/framework repo. |
Contributor
Author
Not a problem, makes sense. 👍 But as per my test repo in https://github.com/magnetikonline/golang-win-cache-test to confirm #651 (as suggested by @brcrista) - these So I'm pretty confident these are in the same vein. |
Contributor
Author
Contributor
Author
|
Thanks @vsvipul |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted by @vsvipul and related to #651 - dropping final mentions of
%AppData%/%LocalAppData%from example docs.