Introduce paths input to support multiple cache paths#180
Closed
kiprasmel wants to merge 4 commits intoactions:masterfrom
Closed
Introduce paths input to support multiple cache paths#180kiprasmel wants to merge 4 commits intoactions:masterfrom
paths input to support multiple cache paths#180kiprasmel wants to merge 4 commits intoactions:masterfrom
Conversation
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Closed
Contributor
|
Hey @sarpik, thanks for the addition! Unfortunately, I don't think this approach will work, as each cache is immutable, so when you upload multiple paths to the same key you'll only succeed on that first upload. We're tracking supporting this feature, but I don't have a timeline at the moment. |
Contributor
Author
|
@joshmgross cheers!:) Sad that this won't work:/ I hope this can be resolved - best of luck! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
TODO - actually restore the cache from the multiple paths.
I'm a little not sure about the
getCacheEntryfunction @cacheHttpClient.ts- see https://github.com/actions/cache/blob/master/src/cacheHttpClient.ts#L86-L88:couldn't there be a case that the
responseis anArray<ArtifactCacheEntry>, since we would've saved multiple caches with different paths for the same keys?TODO - decide what do we want to do with the current
pathinput.Should it be considered deprecated now & removed in v2?