Parse inference response format defensively#97
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements defensive parsing of OpenAI API responses to handle cases where the API returns a string instead of a properly parsed JSON object. It centralizes response handling logic and removes duplicate error handling code.
- Adds a new
chatCompletionwrapper function that defensively parses string responses from the OpenAI API - Refactors both
simpleInferenceandmcpInferencefunctions to use the centralized wrapper - Removes duplicate response validation and error handling code
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Yuzuki-S
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#96
It looks like there was a period where the API was responding without the JSON content type. That shouldn't happen, but if it does we don't need to fail inference on our end either. This PR checks the inference response to see if it's a string and parses it into JSON if so.