Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the process exits cleanly after inference completes by adding process.exit(0) on successful completion, not just on errors. Previously, the application would only force exit when an error occurred, potentially leaving open connections when successful.
- Added
process.exit(0)after successful inference completion - Updated test mocks to handle process exit without throwing errors
- Added assertions to verify proper exit codes in all test scenarios
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main.ts | Added process.exit(0) after successful completion to force clean exit |
| tests/main.test.ts | Updated process.exit mock and added exit code assertions for all test cases |
| tests/main-prompt-integration.test.ts | Added process.exit mock and exit code assertions for integration tests |
Yuzuki-S
previously approved these changes
Aug 6, 2025
Yuzuki-S
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were already doing this on error, but we should do this on success as well - if we're holding a connection open to the MCP server, let's kill the process to clean it up.
We could be keeping a reference to the server and calling
.close()on it in the right spots, but I think it's a bit cleaner to just end the process and let Linux sort it out.