Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a mock inference server for CI testing, eliminating the need for real API credentials during automated tests. The mock server simulates an OpenAI-compatible API endpoint that returns predictable responses.
Key Changes:
- Added a Node.js-based mock inference server that mimics OpenAI's chat completion API
- Updated CI workflows to start the mock server before running tests and stop it afterward
- Removed
continue-on-errorflags from test steps to enforce proper test validation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| script/mock-inference-server.mjs | Creates a mock HTTP server that handles chat completion and health check endpoints for testing |
| .github/workflows/ci.yml | Integrates mock server lifecycle into CI jobs, adds output verification steps, and configures test actions to use the mock endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The temporary file created for response-file was being cleaned up before downstream steps could access it. Now using keep: true to ensure the file persists until the job completes. Also added script/ to eslint ignores for the mock server.
stephaniegiang
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mocks inference so we can remove continue-on-error: true
Also fixes a bug where the response file wasn't being kept around.
#100
#99