Pass GitHub MCP Tools#142
Pass GitHub MCP Tools#142sgoedecke merged 13 commits intoactions:mainfrom maartenvandiemen:feature/pass-toolsets
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring GitHub MCP toolsets by introducing a new github-mcp-toolsets input parameter. This allows users to specify which toolsets (e.g., repos, issues, pull_requests, actions, code_security) should be enabled when connecting to the GitHub MCP server, providing more granular control over available tools.
Key changes:
- Added
github-mcp-toolsetsinput parameter to action.yml with detailed description - Modified
connectToGitHubMCPfunction to accept optional toolsets parameter and include it in theX-MCP-Toolsetsheader when specified - Updated README documentation with usage examples and reference to available toolsets
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcp.ts | Added optional toolsets parameter to connectToGitHubMCP function and logic to conditionally set X-MCP-Toolsets header |
| src/main.ts | Retrieved github-mcp-toolsets input and passed it to connectToGitHubMCP function |
| dist/index.js | Compiled JavaScript output reflecting the TypeScript changes |
| action.yml | Added new github-mcp-toolsets input with comprehensive description of available options |
| tests/mcp.test.ts | Added three new test cases covering default, custom, and empty toolsets scenarios |
| tests/main.test.ts | Updated existing test expectations to include empty string for toolsets parameter |
| README.md | Added new section documenting toolsets configuration with examples, updated version references from v1/v1.2 to v2, and updated inputs table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@maartenvandiemen thanks for creating the fix to this issue, can I expect by when this will be resolved? |
That's depends on the feedback on this PR and when I get it. For the time being I use the version of my PR. Example: Hopefully your policies allow this. Once this PR is merged you will notice it soon enough, the branch will be deleted. |
|
Unfortunately, our enterprise settings won't allow to use this action. Just waiting for team to approve the changes. |
|
@maartenvandiemen Apologies for the delayed review. If you fix the linting errors, I'll re-approve and merge. Please ping me with |
Removed automatic triggers for pull requests and pushes to main branch.
|
@sgoedecke thanks for the review! To be honest I have no clue what is causing the yaml linting issues. I executed the commands locally (Windows) and I don't get any errors. Let's give it another try? |
|
@maartenvandiemen I see this in the logs: Looks like you need to make that a link |
Update GitHub Actions
…diemen/ai-inference into feature/pass-toolsets
|
@sgoedecke thanks for pointing me in the right direction. I've fixed it. I've updated as well all the GitHub Actions to the latest versions available. |
|
Hmm, I wonder if by bumping the linter you've brought in a bunch more linting rules, which are now failing. Up to you if you want to reverse that bump or add fixes/ignores for the new rules. |
|
@maartenvandiemen Thank you for your patience! I'll cut a new release now. |
Thank you as well! Could you also close issue #138? This PR resolves it🙂 |
In a recent change of the GitHub MCP Server some tools are not enabled anymore by default. You need to explicitly define them: https://github.com/github/github-mcp-server?tab=readme-ov-file#tool-configuration.
With this change I introduced an extra optional parameter in which you can pass the tools that the caller want to have enabled.
In issue #138 this is the issue, since the tools for GH Actions aren't enabled by default anymore.