fix: do template substition after parsing prompt YAML#136
Merged
sgoedecke merged 2 commits intoactions:mainfrom Nov 23, 2025
Merged
fix: do template substition after parsing prompt YAML#136sgoedecke merged 2 commits intoactions:mainfrom
sgoedecke merged 2 commits intoactions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #117 by changing when template variable substitution occurs in the prompt file loading process. Instead of replacing template variables in the raw YAML file content before parsing, the substitution now happens after parsing, specifically on the message content fields. This allows template variables to be used within YAML string values without interfering with YAML parsing.
Key changes:
- Template variable substitution moved from pre-parsing to post-parsing stage
- Substitution now applied individually to each message's content field after YAML parsing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sgoedecke
approved these changes
Nov 23, 2025
Contributor
|
Sorry for the delay. Thanks for raising this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117.