Skip to content

Fix --cache-dir not actually being marked as a required flag.#7

Merged
anthonysterling merged 1 commit into
actions:mainfrom
chrisgavin:fix-cache-dir-not-required
Aug 10, 2020
Merged

Fix --cache-dir not actually being marked as a required flag.#7
anthonysterling merged 1 commit into
actions:mainfrom
chrisgavin:fix-cache-dir-not-required

Conversation

@chrisgavin

Copy link
Copy Markdown
Contributor

cache-dir is a persistent flag so the method MarkPersistentFlagRequired is required to mark it as required.

It is currently possible to invoke the tool without passing --cache-dir at all which results in the confusing error message stat : no such file or directory.

@anthonysterling anthonysterling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonysterling anthonysterling merged commit 8cdfdec into actions:main Aug 10, 2020
@chrisgavin chrisgavin deleted the fix-cache-dir-not-required branch August 10, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants