Explicitly set CGO_ENABLED=0#127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #95
Updating
script/buildand.goreleaserto explicitly setCGO_ENABLED=0. This is required after upgrading to Go >=1.20.Even though we're not using CGO directly, some packages in the standard library like
net(that we do use) will implicitly use the CGO implementation if the build environment has the C tools available. Starting in Go1.20the standard library does not ship pre-compiled archives, so to suppress this behavior CGO must be explicitly disabled.See golang/go#58550 for more details
In addition I also made minor changes to the
.goreleaser.ymlconfig to make it easier to read as well as to force the use ofdraftreleases which is implicitly called out in the release docs