Push Notifications for mobile by gnunicorn · Pull Request #945 · acterglobal/a3

gnunicorn · 2023-09-14T08:56:17Z

This contains:

Strong encrypted on rest:
From this point forward all newly registration or logins will have a strong encrypted-on-rest-paradigm installed: upon creation the database we create a random password and use it to encrypt all data stored on disk (within the matrix-sdk store). All this is then kept in the secure enclave ('keychain') of the operation system. Old sessions will be moved over into that enclave though already existing database won't be migrated or encrypted. This was necessary because we couldn't open the unsecured session storage before from the iOS Service Extension (see below), but we can savely open this one.
A new "Push Notifications"-flag is added to the Labs for iOS & Android (with Google Services):
When activated and upon restart, the user will be asked if they want to receive push notifications. When accepted, we are sending over a "pusher" to the homeserver using your newly added $PUSH_SERVER as target (sygnal-servers already deployed).
When receiving a push notification from the server, we are:
a) having a new service that enables us to read and decrypt the event, understanding its content and showing a decrypted message
b) for iOS background services, this PR already contains the necessary Service-Extension and uniffi-swift-plumbing to load the rust service (that's what those makefile changes are about), and it actually works. Unfortunately it isn't able to actually decrypt the data until we have deployed the sliding-sync mechanism, so we are running into a runtime error (theoretically this should just work once we have switched to sliding-sync). In those cases it will show a generic message for the time being (but c) still works)
c) Upon click, regardless of foreground or background, the app will open and route to the corresponding chat-room or space.
Note that if we are in foreground and looking at the chat, not notification is issued (we are usually seconds faster in showing the message in chat compared to when the push-message makes us to the device).

Supported Platforms: iOS & Android.
Instructions for testing: You need to set the PUSH_SERVER or the code will be skipped altogether. For our test-setup use the usual matrix-domain and prefix it with sygnal. (DM me for help if you need it):

diff --git a/.vscode/launch.json b/.vscode/launch.json
index 1d70c46a11..97ea6181bd 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -50,7 +50,9 @@
             "flutterMode": "debug",
             "toolArgs": [
                 "--dart-define",
-                "RAGESHAKE_URL=http://localhost/api/submit"
+                "RAGESHAKE_URL=http://localhost/api/submit",
+                "--dart-define",
+                "PUSH_SERVER=sygnal.SERVER"
             ]
         },
         {

Stil to do:

For later

Desktop Push:
- Windows: https://learn.microsoft.com/en-us/azure/developer/mobile-apps/notification-hubs-backend-service-flutter
- MacOS (similar as for iOS?!?)
- Linux ??? maybe with unifiedPush?

Android:
android push.webm

iOS:

RPReplay_Final1696436232.MP4

…re still fails...

app/ios/Podfile.lock

gtalha07 · 2023-10-19T17:19:10Z

app/lib/common/dialogs/nuke_confirmation.dart

+                text:
+                    'Nuking removes all local data, including encryption keys. If this is your last signed-in device you might no be able to decrypt any previous content.',
+              ),
+              TextSpan(text: 'Are you sure you want to nuke?'),


Nuke seems a strong wording. I would probably go for Erase or Wipe in terms of easy understanding and no assumed double meanings.

It is intentionally strong wording as this is super dangerous... and should only taken if there is no other course of action left ... it won't even back up ... Hence also using the bomb_icon and big-red-letters ...

I mean ... ideally this screen never shows up to a regular user. It only does when we got the underlying SDK into an unrecoverable state - most likely upon startup.

gtalha07 · 2023-10-19T17:21:43Z

app/lib/common/dialogs/nuke_confirmation.dart

+        title: const Column(
+          crossAxisAlignment: CrossAxisAlignment.start,
+          children: [
+            Icon(Atlas.bomb_bold,color: Colors.red,),


I would not be in favor of using this icon, could be brush or some more friendly warning sign...

brush?

It was intended to be something that no one clicks without understanding the risk ... as this is a super-wipe-out without backups ... and see comments as above ...

As in means of cleaning as we can see in some cleaning data apps, anyways I would like to hear what's the general opinion on this via feedback.

gtalha07 · 2023-10-19T17:33:36Z

app/lib/features/activities/providers/notifiers/notifications_list_notifier.dart

-            notify(brief);
-          }
-        }
+        // final provider = ref.watch(featuresProvider);


Why is this commented out? Or its been moved somewhere else? If it is, you can remove comment.

It was some previous code that would show local notifications just coming from our own local supply mechanism and show a local notification regardless of actual push ability on the device ... I suppose we could think about activating something similar again for desktop but we'd have to think about how to phrase that and actually make sure we get the needed data ... I'll remove this for now.

gtalha07 · 2023-10-19T17:35:51Z

app/lib/router/router.dart

+    }
+  } catch (error, trace) {
+    // ignore: deprecated_member_use
+    return state.namedLocation(


Very nice, a better handling approach.

gtalha07 · 2023-10-19T17:40:00Z

docs/content/docs/dev/troubleshooting.md

+
 > Unable to make field private final java.lang.String java.io.File.path accessible: module java.base does not "opens java.io" to unnamed module @7fbe8ef

 If you happen to come across this exception while compiling Android build for application launch, the reason for that is with the flutter fetching the JDK path from Android Studio directory as a default option. This is reported to be occuring in latest **Android Studio Flamingo (2022.2.1)** in reference to the Flutter issue [#106416](https://github.com/flutter/flutter/issues/106416).


this issue had been resolved in newly revised version. We can remove this section of doc :)

gtalha07

Very well put! Excited to try out new stuff.....

app/lib/features/activities/providers/notifiers/notifications_list_notifier.dart

bitfriend · 2023-10-23T16:10:08Z

Great work

gnunicorn and others added 30 commits August 28, 2023 14:21

preparation for push notification handling

983ac88

Merge remote-tracking branch 'origin/main' into ben-let-me-your-pusher

5bb470c

configure android for push notifications

30ded81

hack to support x86_64-linux-android

98b08c2

Acquire push token and set a pusher

e3c7aec

Merge remote-tracking branch 'origin/main' into ben-let-me-your-pusher

a97bcd1

Fix iOS <-> Android mixup

f04ccd1

ignore unset pushServer rather than sending localhost

af318d8

Merge remote-tracking branch 'origin/main' into ben-let-me-your-pusher

6777c4b

Merge remote-tracking branch 'origin/main' into ben-let-me-your-pusher

42db57a

Merge remote-tracking branch 'origin/main' into ben-let-me-your-pusher

db90905

we have the fix in main now

ec1ea85

Merge remote-tracking branch 'origin/main' into ben-let-me-your-pusher

825d49a

Background push notifications infra

e374b1f

background push for iOS

317c8d9

ios Push Background Infra

08c0bf2

switch to latest awesome_notifications

dafce6d

better background handler for iOS

1354555

Switch to forken plain_notifications for better Android support

9505899

identify message target via device_id

83f3c0f

replace awesome notifications and plain token with simpler push-package

984ee13

more push refinements

7780897

Notification Item Support from rust side

991e195

new notification fetching infrastructure

c187c65

show a notification after it being decrypted

6561227

define platform support

f4e6de4

upgrading local notif

6c225a0

Store new session in encrypted format now. Refs #608

125702b

attempt to switching to flutter secure storage, refs #608 - but resto…

ff46e96

…re still fails...

add notificaiton icons

42d99ad

gnunicorn added 3 commits October 17, 2023 16:25

Add Labs and Security User Docs

278a0be

fixing style

3f5f7fb

free disk space on rust integration test, too

a189b47

gnunicorn force-pushed the ben-let-me-your-pusher branch 2 times, most recently from 6513d3b to 9af1f93 Compare October 18, 2023 09:05

Merge remote-tracking branch 'origin/main' into ben-let-me-your-pusher

f6edbe0

gnunicorn force-pushed the ben-let-me-your-pusher branch from 9af1f93 to f6edbe0 Compare October 18, 2023 10:07

gnunicorn requested review from bitfriend and gtalha07 and removed request for bitfriend October 18, 2023 12:27

This was referenced Oct 18, 2023

Implement Notification level configuration #1059

Merged

Configure pushers #1062

Merged

gtalha07 reviewed Oct 19, 2023

View reviewed changes

app/ios/Podfile.lock Show resolved Hide resolved

gtalha07 reviewed Oct 19, 2023

View reviewed changes

gtalha07 approved these changes Oct 19, 2023

View reviewed changes

gnunicorn commented Oct 19, 2023

View reviewed changes

app/lib/features/activities/providers/notifiers/notifications_list_notifier.dart Outdated Show resolved Hide resolved

gnunicorn commented Oct 19, 2023

View reviewed changes

app/lib/features/activities/providers/notifiers/notifications_list_notifier.dart Outdated Show resolved Hide resolved

Remove old code

121bd29

gnunicorn mentioned this pull request Oct 19, 2023

Default Notification Settings #1063

Closed

gnunicorn added 3 commits October 23, 2023 15:10

Merge remote-tracking branch 'origin/main' into ben-let-me-your-pusher

ee6b7ed

format fixes

895ecc8

switch to proper upstream flutter_secure_storage

2220ae2

gnunicorn enabled auto-merge October 23, 2023 14:47

gnunicorn merged commit 2d8a70f into main Oct 23, 2023

gnunicorn deleted the ben-let-me-your-pusher branch October 23, 2023 15:30


		> Unable to make field private final java.lang.String java.io.File.path accessible: module java.base does not "opens java.io" to unnamed module @7fbe8ef

		If you happen to come across this exception while compiling Android build for application launch, the reason for that is with the flutter fetching the JDK path from Android Studio directory as a default option. This is reported to be occuring in latest Android Studio Flamingo (2022.2.1) in reference to the Flutter issue [#106416](https://github.com/flutter/flutter/issues/106416).

Uh oh!

Conversation

gnunicorn commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gtalha07 Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnunicorn Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

gtalha07 Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnunicorn Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

gtalha07 Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gtalha07 Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

gnunicorn Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

gtalha07 Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

gtalha07 Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gtalha07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bitfriend commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gnunicorn commented Sep 14, 2023 •

edited

Loading

gtalha07 Oct 19, 2023 •

edited

Loading

gtalha07 Oct 19, 2023 •

edited

Loading

gtalha07 Oct 19, 2023 •

edited

Loading

gtalha07 Oct 19, 2023 •

edited

Loading