autocomplete: remove invalid example#1653
Merged
WilcoFiers merged 2 commits intodevelopfrom Jul 15, 2021
Merged
Conversation
This example should have been removed when we changed the rule to no longer require the autocomplete be on an appropriate input type.
carlosapaduarte
approved these changes
Jun 18, 2021
ajanec01
previously requested changes
Jun 18, 2021
Collaborator
ajanec01
left a comment
There was a problem hiding this comment.
I think the original idea was to catch an input with incorrect programmatic purpose. Yes, the example is wrong but I feel that we should change it to:
<label>Email<input autocomplete="impp" /><label>
ajanec01
approved these changes
Jun 22, 2021
Jym77
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example should have been removed when we changed the rule to no longer require the autocomplete be on an appropriate input type.
Need for Final Call: 1 week
How to Review And Approve