Skip to content

Autocomplete has valid value 73f2c2#1583

Merged
ajanec01 merged 10 commits intodevelopfrom
autocomplete-has-valid-value
Jun 7, 2021
Merged

Autocomplete has valid value 73f2c2#1583
ajanec01 merged 10 commits intodevelopfrom
autocomplete-has-valid-value

Conversation

@ajanec01
Copy link
Copy Markdown
Collaborator

Applying suggestions from the previous CG call.

Closes issue(s):

No need for final call.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@ajanec01 ajanec01 self-assigned this Apr 24, 2021
@ajanec01 ajanec01 changed the title applying changes in response to Wilco's and Jym77's suggestions Autocomplete has valid value 73f2c2 Apr 24, 2021
Copy link
Copy Markdown
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple editorial suggestions. Rest looks great.

ajanec01 and others added 4 commits April 27, 2021 13:26
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@ajanec01 ajanec01 requested a review from WilcoFiers April 27, 2021 12:32
@ajanec01 ajanec01 dismissed WilcoFiers’s stale review April 27, 2021 12:33

All suggestions commited.

Jym77
Jym77 previously requested changes May 6, 2021
ajanec01 and others added 2 commits May 8, 2021 23:25
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
@ajanec01 ajanec01 requested a review from Jym77 May 8, 2021 22:26
@ajanec01 ajanec01 dismissed Jym77’s stale review May 8, 2021 22:26

All done!

Copy link
Copy Markdown
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits

Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
@ajanec01 ajanec01 requested a review from carlosapaduarte June 2, 2021 22:03
@ajanec01 ajanec01 dismissed carlosapaduarte’s stale review June 2, 2021 22:04

Committed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

autocomplete="off" fails "autocomplete attribute has valid value" (73f2c2)

4 participants