Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
4e230af to
b65360f
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
…isal/acp-42-remove-hardhat-and-all-hardhat-related-dependencies
…isal/acp-42-remove-hardhat-and-all-hardhat-related-dependencies
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
…isal/acp-42-remove-hardhat-and-all-hardhat-related-dependencies
There was a problem hiding this comment.
Hmm, what are we using hardhat-deploy for now?
There was a problem hiding this comment.
we are not using it, but @uma/common still uses it and for some reason @uma/common doesn't have hardhat installed (which hardhat-deploy depends on). so need to stub out hardhat types here
grasphoper
left a comment
There was a problem hiding this comment.
o7
Left a few Qs, a lot of great removals :)
Have you tested with downstream repos, e.g. relayer? Does this work for relayer out of the box or no?
…isal/acp-42-remove-hardhat-and-all-hardhat-related-dependencies
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
…isal/acp-42-remove-hardhat-and-all-hardhat-related-dependencies
|
@grasphoper yes tested with other repos |
…isal/acp-42-remove-hardhat-and-all-hardhat-related-dependencies
tbwebb22
left a comment
There was a problem hiding this comment.
Nice! just one nit: there are a couple references to hardhat still in the readme that I think can be removed
…isal/acp-42-remove-hardhat-and-all-hardhat-related-dependencies
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
…isal/acp-42-remove-hardhat-and-all-hardhat-related-dependencies
No description provided.