Skip to content

Vultr Api: Update to v2#4192

Merged
neilpang merged 1 commit intoacmesh-official:devfrom
skyksandr:master
Jul 19, 2022
Merged

Vultr Api: Update to v2#4192
neilpang merged 1 commit intoacmesh-official:devfrom
skyksandr:master

Conversation

@skyksandr
Copy link
Copy Markdown
Contributor

I ran into rate limits when trying to issue single cert for 3 domains.

  • Vultr Api v1 has rate limit of 2 requests per seconds (source)
  • Vultr Api v2 - 30 requests per second (source)

In this PR I have updated:

  • endpoints
  • Auth header: from Api-Key: ... to Authorization: Bearer ...
  • Content-Type to application/json

I have verified it working using GitHub Actions https://github.com/skyderby/skyderby/runs/7378330990?check_suite_focus=true

@neilpang
Copy link
Copy Markdown
Member

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

- change endpoints
- change Api-Key header to Authorization: Bearer
@skyksandr
Copy link
Copy Markdown
Contributor Author

skyksandr commented Jul 18, 2022

@neilpang done that, could you verify it: https://github.com/skyksandr/acme.sh/actions/runs/2688142460

Also shell check suggests to double quote $VULTR_API_KEY to prevent globbing. What is your opinion on it?

api_key_trimmed=$(echo $VULTR_API_KEY | tr -d '"')

@neilpang neilpang merged commit de04192 into acmesh-official:dev Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants