Conversation
eoinkelly
commented
Nov 24, 2024
| # The original asset pipeline for Rails [https://github.com/rails/sprockets-rails] | ||
| gem "sprockets-rails" | ||
| # The modern asset pipeline for Rails [https://github.com/rails/propshaft] | ||
| gem "propshaft" |
Contributor
Author
There was a problem hiding this comment.
todo: Verify we still need propshaft given we use shakapacker.
G-Rath
reviewed
Mar 16, 2025
|
|
||
| # TODO: https://github.com/ackama/rails-template/issues/569 | ||
| insert_into_file "config/environments/production.rb", | ||
| after: /.*config\.public_file_server\.enabled.*\n/ do |
Contributor
There was a problem hiding this comment.
issue: I don't see how this can match, because the Rails 8 config does not include this anymore by default
64e9658 to
5bac7db
Compare
c0418ef to
7d4d7b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eoin's PR description
This is mostly there. Just needs some tidy-up once we make decisions about the outstanding issues tagged with
Rails 8Copilot's PR description
This pull request includes several changes to the CI configuration, template application, and documentation to improve compatibility and maintainability. The most important changes include modifications to the CI workflow file, updates to the template application process, and adjustments to the documentation to reflect new options.
CI Workflow Updates:
.github/workflows/ci.yml: Renamed thetest_generated_appsjob toappsfor better readability in the GitHub UI..github/workflows/ci.yml: Temporarily disabled multiplejs_package_manageroptions to simplify the CI process..github/workflows/ci.yml: Updated theSKIPSenvironment variable to include additional skip options (--skip-kamaland--skip-solid).Template Application Enhancements:
template.rb: Added terminal output statements to indicate the start and end of significant blocks during the template application process. [1] [2] [3]template.rb: Corrected the file name for the ERB lint configuration and updated the linting command.Documentation Updates:
README.md: Updated example commands to include new skip options (--skip-kamaland--skip-solid). [1] [2]Dependency and Configuration Adjustments:
target_versions.yml: Updated the target Rails version to8.0and the minimum Ruby version to3.2.variants/accessibility/Gemfile.rb: Added a terminal output statement to indicate the installation of accessibility checking gems.These changes aim to streamline the CI process, enhance the clarity of the template application, and ensure the documentation is up-to-date with the latest options and configurations.