Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some metadata changes. Let's see if you agree with them.
Remove "heavily WIP" from description. This crate has been around for a long time now and is used a lot. The API is already very usable and handy. Just because there will be more breaking releases does not mean the entire crate is in some early work in progress state IMO. A bit more cleanup and API fixes and I rather think we should go 1.0. Such a fundamental library should be able to be "stable". Which in turn does not mean there can never be a 2.0, just that it's ready for general use. Which this already is, by far.
Add
cidrkeyword.Remove "os" category. The description of that category on crates.io is "Bindings to operating system-specific APIs.". This crate does not bind to/call any OS APIs.
Add "parser-implementation" category. Since this crate implements parsing a specific format (cidr).