ipnetwork: add netmask constructors#103
Merged
achanda merged 2 commits intoachanda:masterfrom Nov 28, 2019
Merged
Conversation
This adds constructors to build all network types from a network address and network mask pair.
Owner
|
Thanks @lucab ! |
Contributor
Author
|
@achanda thank you for maintaining this! |
Owner
|
Thanks for the pointer. I can cut a release today if this is required now. Otherwise, I was planning to do it mid-December. |
Contributor
Author
|
No worries, it will take some time any way for all the bits to be in place. I'll jump on the new version without hurry once it's available, and in the meanwhile the small bit of logic duplication is perfectly fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds constructors to build all network types from a network
address and network mask pair.
It also
rustfmtthe whole project.