Merge pull request #144 from paolobarbolini/collect-str

achanda · web-flow · commit 7120b9383769 · 2021-12-29T10:24:38.000-06:00
Remove useless allocation when serializing
diff --git a/src/ipv4.rs b/src/ipv4.rs
@@ -27,7 +27,7 @@ impl serde::Serialize for Ipv4Network {
     where
         S: serde::Serializer,
     {
-        serializer.serialize_str(&self.to_string())
+        serializer.collect_str(self)
     }
 }
 
diff --git a/src/ipv6.rs b/src/ipv6.rs
@@ -28,7 +28,7 @@ impl serde::Serialize for Ipv6Network {
     where
         S: serde::Serializer,
     {
-        serializer.serialize_str(&self.to_string())
+        serializer.collect_str(self)
     }
 }
 
diff --git a/src/lib.rs b/src/lib.rs
@@ -46,7 +46,7 @@ impl serde::Serialize for IpNetwork {
     where
         S: serde::Serializer,
     {
-        serializer.serialize_str(&self.to_string())
+        serializer.collect_str(self)
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ impl serde::Serialize for Ipv4Network {`
`27`	`27`	`where`
`28`	`28`	`S: serde::Serializer,`
`29`	`29`	`{`
`30`		`- serializer.serialize_str(&self.to_string())`
	`30`	`+ serializer.collect_str(self)`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ impl serde::Serialize for Ipv6Network {`
`28`	`28`	`where`
`29`	`29`	`S: serde::Serializer,`
`30`	`30`	`{`
`31`		`- serializer.serialize_str(&self.to_string())`
	`31`	`+ serializer.collect_str(self)`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ impl serde::Serialize for IpNetwork {`
`46`	`46`	`where`
`47`	`47`	`S: serde::Serializer,`
`48`	`48`	`{`
`49`		`- serializer.serialize_str(&self.to_string())`
	`49`	`+ serializer.collect_str(self)`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`