Conversation
|
This is getting out of hand, now there's two of them! @johnb432 |
|
Not reviewing yet, but we typically end files with a newline, FYI. |
b232036 to
ac0921a
Compare
johnb432
left a comment
There was a problem hiding this comment.
- Don't force push, it breaks stuff.
- I'm not a fan of hogging the
hintUI for an undetermined amount of time. QTE should have its own dedicated UI. - No timeout option, meaning this will last forever until the QTE is solved.
Lastly: Why add this to ACE? What are the use cases? I can't imagine any use cases, but you are bound to have some.
Usage:
|
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
For me, I would like to add QTE's (given the API is simple) to reduce some progress bars. IMO this makes more sense as a CBA thing, but for ACE specifically I would add a QTE for CSW tripod and gun assembly, maybe patting out fires in |
|
Put development of this on hold for now, we're having an internal discussion of how QTE should be implemented into ACE. |
|
@johnb432 Any update? |
|
I don't want to be too hasty about it, but atm it seems like a QTE framework would make more sense to be added in CBA. However, internal discussion is still ongoing. |
That would make sense to me. I assume we would have a callback for display events to allow ACE to have its own UI system. |
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.TODO:
waitUntilto wait for correct input or move away (Help Needed)