Skip to content

Add Quick Time Events#9849

Closed
john681611 wants to merge 18 commits intoacemod:masterfrom
john681611:quickTimeEvents
Closed

Add Quick Time Events#9849
john681611 wants to merge 18 commits intoacemod:masterfrom
john681611:quickTimeEvents

Conversation

@john681611
Copy link
Copy Markdown
Contributor

@john681611 john681611 commented Mar 12, 2024

When merged this pull request will:

  • Provide Quick Time Events for players to enter in order to complete action (capability addition not change any existing functionality)

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

TODO:

  • Fix no longer being able to use waitUntil to wait for correct input or move away (Help Needed)
  • Distance parameter + Default
  • Localisation
  • Keybind (Help Needed)
  • Sanitisation
  • Timeout
  • Hint alternative
  • Completed callback

@LinkIsGrim
Copy link
Copy Markdown
Member

This is getting out of hand, now there's two of them! @johnb432

@LinkIsGrim
Copy link
Copy Markdown
Member

Not reviewing yet, but we typically end files with a newline, FYI.

@john681611 john681611 marked this pull request as ready for review March 13, 2024 09:58
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't force push, it breaks stuff.
  • I'm not a fan of hogging the hint UI for an undetermined amount of time. QTE should have its own dedicated UI.
  • No timeout option, meaning this will last forever until the QTE is solved.

Lastly: Why add this to ACE? What are the use cases? I can't imagine any use cases, but you are bound to have some.

@john681611
Copy link
Copy Markdown
Contributor Author

  • Don't force push, it breaks stuff.
  • I'm not a fan of hogging the hint UI for an undetermined amount of time. QTE should have its own dedicated UI.
  • No timeout option, meaning this will last forever until the QTE is solved.

Lastly: Why add this to ACE? What are the use cases? I can't imagine any use cases, but you are bound to have some.

  • Happy to understand a replacement for hint I'm converting from an in-mission script I wrote.
  • Timout: Fair call will be added to the TODO list

Usage:

  • To give players an option to have a skill-based interaction rather than waiting out a 'progress bar' for many interactions (mostly medical).
  • Low-tech way of simulating actions to create memorable patterns for completing actions (or random ones for others)
  • Allow player stress to affect their performance in interactions.
  • (weak) Unconscious Mini game that give the player something to do (maybe affecting wakeup/death chance) that gives players something to do rather than go AFK for far too long.

john681611 and others added 12 commits March 13, 2024 17:40
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@TheCandianVendingMachine
Copy link
Copy Markdown
Contributor

Lastly: Why add this to ACE? What are the use cases? I can't imagine any use cases, but you are bound to have some.

For me, I would like to add QTE's (given the API is simple) to reduce some progress bars. IMO this makes more sense as a CBA thing, but for ACE specifically I would add a QTE for CSW tripod and gun assembly, maybe patting out fires in fire. Just something for players to be engaged by, and to reward more skilled players with faster outcomes.

@johnb432
Copy link
Copy Markdown
Contributor

Put development of this on hold for now, we're having an internal discussion of how QTE should be implemented into ACE.

@john681611
Copy link
Copy Markdown
Contributor Author

@johnb432 Any update?

@johnb432
Copy link
Copy Markdown
Contributor

I don't want to be too hasty about it, but atm it seems like a QTE framework would make more sense to be added in CBA.
ACE would have a progress bar that would use said framework.

However, internal discussion is still ongoing.

@john681611
Copy link
Copy Markdown
Contributor Author

I don't want to be too hasty about it, but atm it seems like a QTE framework would make more sense to be added in CBA. ACE would have a progress bar that would use said framework.

However, internal discussion is still ongoing.

That would make sense to me. I assume we would have a callback for display events to allow ACE to have its own UI system.

@john681611 john681611 marked this pull request as draft March 25, 2024 11:59
@john681611 john681611 closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants