Medical Engine - Improve damage calculation for explosive-resistant armor#9216
Merged
LinkIsGrim merged 20 commits intoacemod:masterfrom Sep 23, 2023
Merged
Medical Engine - Improve damage calculation for explosive-resistant armor#9216LinkIsGrim merged 20 commits intoacemod:masterfrom
LinkIsGrim merged 20 commits intoacemod:masterfrom
Conversation
Member
Author
|
Here's some math: This is just taking the base armor into account. Ingame damage values are going to be lower due to units' innate armor. |
Member
Author
|
Marked as WIP. High damage diverts to limbs again. |
rautamiekka
reviewed
Jun 14, 2023
rautamiekka
reviewed
Jun 14, 2023
rautamiekka
reviewed
Jun 14, 2023
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Member
Author
|
Fixed the sorting, though if anyone has a more elegant solution, I'll take it. |
3 tasks
3 tasks
Mike-MF
approved these changes
Sep 19, 2023
Member
Mike-MF
left a comment
There was a problem hiding this comment.
I tested it, it works as advertised. Someone other than me should probably review the code though.
veteran29
approved these changes
Sep 23, 2023
Member
Author
|
FINALLY, BEGONE ISSUES |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I've only done limited testing but this doesn't seem to break fire/fall damage/drowning/explosives or have anything beyond the intended effect on wound creation.Doesn't break anything.
This also improves protection from vests and helmets against pistol calibers, especially the lower tier tactical vests and armored uniforms as a side effect, but this is closer to expected performance when using vanilla as a reference.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.