Skip to content

Compat SPE - Fix dropped SPE CSWs not converting to ACE CSWs#11312

Merged
PabstMirror merged 4 commits intomasterfrom
compat-spe-handle-inventory-drop
Mar 24, 2026
Merged

Compat SPE - Fix dropped SPE CSWs not converting to ACE CSWs#11312
PabstMirror merged 4 commits intomasterfrom
compat-spe-handle-inventory-drop

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • When you drop SPE CSWs from your inventory, there is a script that converts them into objects instead of leaving them as inventory items. This script didn't account for ACE CSWs, so I overwrote it.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added this to the 3.21.0 milestone Mar 13, 2026
@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Mar 13, 2026
@johnb432 johnb432 changed the title Compat SPE - Fixed dropped SPE CSWs not converting to ACE CSWs Compat SPE - Fix dropped SPE CSWs not converting to ACE CSWs Mar 13, 2026
@johnb432 johnb432 marked this pull request as ready for review March 19, 2026 11:40
_container addItemCargoGlobal [_item, -1];

// Create a vehicle replacing the tripod
private _pos = (getPosATL _unit) vectorAdd (_vectorDir vectorMultiply 1.1);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it wants AGL (so ASLtoAGL getPosASL _unit)?
but I'm guessing this is part of the original func so it's probably best to leave it alone

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I'm guessing this is part of the original func so it's probably best to leave it alone

It is, but I've already extensively rewritten most of the function anyway, so I'll change it.

@PabstMirror PabstMirror merged commit 043a5ff into master Mar 24, 2026
3 checks passed
@PabstMirror PabstMirror deleted the compat-spe-handle-inventory-drop branch March 24, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants