Skip to content

Common - Add status effect for setPhysicsCollisionFlag#11230

Merged
PabstMirror merged 2 commits intoacemod:masterfrom
DartRuffian:setPhysicsCollisionFlag-statusEffect
Feb 1, 2026
Merged

Common - Add status effect for setPhysicsCollisionFlag#11230
PabstMirror merged 2 commits intoacemod:masterfrom
DartRuffian:setPhysicsCollisionFlag-statusEffect

Conversation

@DartRuffian
Copy link
Copy Markdown
Contributor

@DartRuffian DartRuffian commented Jan 12, 2026

When merged this pull request will:

  • Title

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@DartRuffian
Copy link
Copy Markdown
Contributor Author

DartRuffian commented Jan 12, 2026

The _set > 0 may need to be flipped, wasn't working when I tried using it with reason1 being true and reason2 being false.
Will mess with it more but I have work

@PabstMirror
Copy link
Copy Markdown
Contributor

PabstMirror commented Jan 12, 2026

true to enable collision, false to disable it

I think the goal is to disable when any flags are set
So we may want to invert the logic and the name?

@DartRuffian
Copy link
Copy Markdown
Contributor Author

DartRuffian commented Jan 12, 2026

Probably, I flipped the _set bit but didn't have time to test it before work

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jan 12, 2026
@PabstMirror PabstMirror added this to the 3.20.3 milestone Jan 12, 2026
@DartRuffian
Copy link
Copy Markdown
Contributor Author

DartRuffian commented Jan 13, 2026

Should the name maybe just be disableCollision? Very different name but not really sure what else would work

@johnb432
Copy link
Copy Markdown
Contributor

johnb432 commented Jan 18, 2026

I'd really like to move these to CBA at some point, so more mods can utilize the system, so mods step less on each others toes.

@DartRuffian
Copy link
Copy Markdown
Contributor Author

DartRuffian commented Jan 18, 2026 •
edited
Loading

That'd be great, just want them in CBA's common?

@johnb432
Copy link
Copy Markdown
Contributor

johnb432 commented Jan 18, 2026

That'd be great, just want them in CBA's common?

I don't really know, but at this stage it's only a wish on my part.

@DartRuffian
Copy link
Copy Markdown
Contributor Author

DartRuffian commented Jan 18, 2026 •
edited
Loading

I did a lot of the "grunt work" in CBATeam/CBA_A3#1809 if you'd like to look. I'd really like them in CBA for some other mods where I can't have ace as a requirement

@PabstMirror PabstMirror merged commit bba36ce into acemod:master Feb 1, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@johnb432 johnb432 johnb432 approved these changes

Assignees

No one assigned

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Milestone

3.21.0

Development

Successfully merging this pull request may close these issues.

3 participants

@DartRuffian @PabstMirror @johnb432