Skip to content

Medical - SpO2 Duty Factor#11218

Merged
PabstMirror merged 3 commits intoacemod:masterfrom
BrettMayson:spo2_duty_factor
Jan 19, 2026
Merged

Medical - SpO2 Duty Factor#11218
PabstMirror merged 3 commits intoacemod:masterfrom
BrettMayson:spo2_duty_factor

Conversation

@BrettMayson
Copy link
Copy Markdown
Member

@BrettMayson BrettMayson commented Jan 6, 2026

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@SpicyBagpipes
Copy link
Copy Markdown
Contributor

SpicyBagpipes commented Jan 6, 2026

LGTM wrt implementation, only thing I could foresee issues with is potentially instances where people want oxygen to be leaving the unit's lungs at a higher rate than no breathing but probably fine

Ignore, I'm stupid... You still exhale all that oxygen, you don't lose oxygen any faster

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Jan 7, 2026

LGTM wrt implementation, only thing I could foresee issues with is potentially instances where people want oxygen to be leaving the unit's lungs at a higher rate than no breathing but probably fine

Having that might be nice for medical, explosions or torso hits could knock the wind out of players.

@SpicyBagpipes
Copy link
Copy Markdown
Contributor

knocking the wind out of someone is not removing oxygen from their blood.

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Jan 7, 2026

knocking the wind out of someone is not removing oxygen from their blood.

oxygen to be leaving the unit's lungs

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@BrettMayson
Copy link
Copy Markdown
Member Author

All of this is just a copy paste from the stamina duty factor

@johnb432

This comment was marked as resolved.

@PabstMirror PabstMirror added this to the 3.20.3 milestone Jan 10, 2026
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jan 10, 2026
@PabstMirror PabstMirror requested a review from johnb432 January 17, 2026 22:44
@PabstMirror PabstMirror merged commit f89b600 into acemod:master Jan 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants