Skip to content

Common - Remove Request Framework#11183

Merged
PabstMirror merged 1 commit intomasterfrom
common-delete-requests
Feb 1, 2026
Merged

Common - Remove Request Framework#11183
PabstMirror merged 1 commit intomasterfrom
common-delete-requests

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Request Framework has been broken for as long as it's been added (unless Arma behaviour has changed since and it only broke afterwards):
    GVAR(RECIEVE_REQUEST_ADD_ACTION_ACCEPT) = _target addAction ["Accept", compile format["[player,'%1', true] call FUNC(onAnswerRequest);", _requestID]];
    throws an error, because FUNC(onAnswerRequest) is not preprocessed into a valid function name.
  • Framework is extremely limited, to the point it's not useful in my opinion. If other mods need such a framework, they can easily make their own.
    • It can only handle 1 request at a time.
    • It uses vanilla hints.
    • It uses vanilla actions instead of ACE interactions.
    • You can't customise the action name.
    • You can't pass custom arguments.
  • I have been working on modernising the code, but after several attempts I have always come to the conclusion that the framework is not useful and very likely not even used, so not worth updating.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/cleanup Release Notes: **CHANGED:** label Dec 22, 2025
@LinkIsGrim
Copy link
Copy Markdown
Member

While I agree, we should mark deprecation first.

@johnb432
Copy link
Copy Markdown
Contributor Author

While I agree, we should mark deprecation first.

How?

@PabstMirror
Copy link
Copy Markdown
Contributor

I guess add ACE_DEPRECATED("request framework",3.21,"nothing");
to each sqf (or maybe just the top level one)

but if it has never worked I think we can go straight to removal, as there is nothing to break

@PabstMirror PabstMirror added this to the 3.20.3 milestone Dec 23, 2025
@PabstMirror PabstMirror merged commit 78d46f0 into master Feb 1, 2026
3 checks passed
@PabstMirror PabstMirror deleted the common-delete-requests branch February 1, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Release Notes: **CHANGED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants