Markers - Fix script error on profiling branch (radioChannelInfo)#11138
Merged
PabstMirror merged 1 commit intomasterfrom Nov 22, 2025
Merged
Markers - Fix script error on profiling branch (radioChannelInfo)#11138PabstMirror merged 1 commit intomasterfrom
radioChannelInfo)#11138PabstMirror merged 1 commit intomasterfrom
Conversation
johnb432
approved these changes
Nov 16, 2025
PabstMirror
commented
Nov 22, 2025
| // Micro-optimization so we don't rebuild the array and localize in each iteration | ||
| private _engineChannels = CHANNEL_NAMES; | ||
|
|
||
| for "_channelId" from 0 to 15 do { |
Contributor
Author
There was a problem hiding this comment.
noting they are planning on adding more channels,
so this hardcoded 15 will have to be changed in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
radioChannelInfo -1 now returns []
so the select fails