Wardrobe - Add onItemChanged* Events#11137
Merged
PabstMirror merged 16 commits intoacemod:masterfrom Nov 22, 2025
Merged
Conversation
PabstMirror
reviewed
Nov 16, 2025
PabstMirror
reviewed
Nov 16, 2025
PabstMirror
approved these changes
Nov 16, 2025
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
LinkIsGrim
approved these changes
Nov 16, 2025
LinkIsGrim
reviewed
Nov 16, 2025
Member
LinkIsGrim
left a comment
There was a problem hiding this comment.
Might be overkill, but maybe before and after events instead of a single event? And add the equipment type to the event args.
Contributor
Author
Can add the type. |
johnb432
requested changes
Nov 16, 2025
Contributor
johnb432
left a comment
There was a problem hiding this comment.
This has to be inserted at line 55 of FUNC(replace), because _classOrigin isn't passed to the replace functions.
Also if we add other functions in the future, we don't have to think about adding the 'after' event on a per function/file basis. So line 55 would be like:
[{
params ["_player", "_classOrigin", "_classTarget", "_equipmentType", "_replaceCode"];
[_player, _classTarget, _equipmentType] call _replaceCode;
[QGVAR(itemChangedAfter), [_player, _classOrigin, _classTarget, _equipmentType]] call CBA_fnc_localEvent;
}, [_player, _classOrigin, _classTarget, _equipmentType, _replaceCode], _duration] call CBA_fnc_waitAndExecute;
johnb432
approved these changes
Nov 16, 2025
TheCandianVendingMachine
requested changes
Nov 16, 2025
TheCandianVendingMachine
approved these changes
Nov 17, 2025
johnb432
reviewed
Nov 17, 2025
onItemChanged* Events
johnb432
approved these changes
Nov 19, 2025
TheCandianVendingMachine
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.