Skip to content

Vehicle Damage - Execute allowCrewInImmobile only where vehicle is local#11082

Merged
PabstMirror merged 1 commit intomasterfrom
vehicle-damage/allowCrewInImmobile
Oct 11, 2025
Merged

Vehicle Damage - Execute allowCrewInImmobile only where vehicle is local#11082
PabstMirror merged 1 commit intomasterfrom
vehicle-damage/allowCrewInImmobile

Conversation

@veteran29
Copy link
Copy Markdown
Member

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@veteran29 veteran29 added the kind/bug-fix Release Notes: **FIXED:** label Oct 8, 2025
@dedmen
Copy link
Copy Markdown
Contributor

dedmen commented Oct 8, 2025

"Ref to nonnetwork object" spam in RPT

Player 1 spawns vehicle, runs Init script locally, sets the CrewInImmo flag.
Player 2 receives spawn via network, runs init script locally, tries to send network message to Player 1 that he should set CrewInImmo flag. Fails due to initialization order in engine, networkId not assigned yet.
Player 3 receives spawn, sends message to Player 1.
Player 4, 5, 6, ...

Every player spams the owner to set a flag that he already set anyway.

This pattern is probably also an issue in other init scripts? They should generally not do things that send network messages, because every player would do it.

@johnb432 johnb432 added this to the 3.20.1 milestone Oct 11, 2025
@PabstMirror PabstMirror merged commit eb26bc3 into master Oct 11, 2025
3 checks passed
@PabstMirror PabstMirror deleted the vehicle-damage/allowCrewInImmobile branch October 11, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants