Skip to content

Medical - Binarize most configs#11080

Merged
PabstMirror merged 1 commit intomasterfrom
medBinCfg
Oct 13, 2025
Merged

Medical - Binarize most configs#11080
PabstMirror merged 1 commit intomasterfrom
medBinCfg

Conversation

@PabstMirror
Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror commented Oct 6, 2025

No description provided.

@PabstMirror PabstMirror added this to the Ongoing milestone Oct 6, 2025
@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Oct 6, 2025
@PabstMirror PabstMirror mentioned this pull request Oct 6, 2025
Merged
@johnb432
Copy link
Copy Markdown
Contributor

johnb432 commented Oct 11, 2025

I don't quite understand what this PR is trying to accomplish. As far as I can tell, the No Medical addon won't do its job anymore - or have I misunderstood?

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Oct 11, 2025

I don't quite understand what this PR is trying to accomplish. As far as I can tell, the No Medical addon won't do its job anymore - or have I misunderstood?

#11081 will use skipWhenAnyAddonPresent to not load ace_medical_engine if ace_nomedical is present.
If ace_medical_engine isn't loaded, then the skipWhenMissingDependencies added here will prevent the other medical addons from being loaded as well.

@PabstMirror PabstMirror modified the milestones: Ongoing, 3.20.1 Oct 13, 2025
@PabstMirror PabstMirror merged commit 81051af into master Oct 13, 2025
3 checks passed
@PabstMirror PabstMirror deleted the medBinCfg branch October 13, 2025 18:22
@johnb432 johnb432 changed the title Medical - Binerize most configs Medical - Binarize most configs Oct 14, 2025
@PabstMirror PabstMirror mentioned this pull request Feb 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrettMayson BrettMayson BrettMayson approved these changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees

No one assigned

Labels

kind/cleanup Release Notes: **CHANGED:**

Projects

None yet

Milestone

3.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

@PabstMirror @johnb432 @Drofseh @BrettMayson @LinkIsGrim